(graphcache) - fix no selectionset mutation updates in optimistic phase #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 0d05c91 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I fixed the codesandbox in this PR #656 |
kitten
approved these changes
Mar 22, 2020
| @@ -247,7 +247,7 @@ const writeSelection = ( | |||
| } else if (entityKey && !isRoot) { | |||
| // This is a leaf node, so we're setting the field's value directly | |||
| InMemoryData.writeRecord(entityKey || typename, fieldKey, fieldValue); | |||
| } | |||
| } else if (ctx.optimistic && isRoot) continue; | |||
There was a problem hiding this comment.
Should we leave a TODO here for scalar optimistic results or just address that in a subsequent PR?
I’d have time to take a look at that, because I suppose it’s expected behaviour 🤷♀️
There was a problem hiding this comment.
I'd like to defer this to a later PR, if you don't get to it I can also look into it no pressure 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Their was a scenario where a mutation without selectionset would cause a call to its respective updater function.
As you can see the above has no selectionset, this would cause the
writeSelectionSetnot to check if there was an actual optimistic-entry for the current rootFieldFixes: #653
Set of changes